Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check for hardware_interface #882

Conversation

Yadunund
Copy link
Member

Fix #881

Latest version of hardware_interface on Rolling is 4.2.0

Signed-off-by: Yadunund <[email protected]>
@Yadunund
Copy link
Member Author

cc: @omichel

@omichel omichel self-requested a review January 16, 2024 13:56
@omichel omichel added the bug Something isn't working label Jan 16, 2024
@omichel omichel added this to the 2023.1.2 milestone Jan 16, 2024
@omichel omichel changed the base branch from master to fix_hw_interface_check January 16, 2024 13:58
@omichel omichel merged commit a73c083 into cyberbotics:fix_hw_interface_check Jan 16, 2024
6 of 7 checks passed
@omichel omichel mentioned this pull request Jan 16, 2024
@omichel
Copy link
Member

omichel commented Jan 16, 2024

I moved your PR to #883 (on this repository), so that we can perform the CI tests.

@Yadunund
Copy link
Member Author

Thanks for the quick follow up! Really appreciate it!

@Yadunund Yadunund deleted the yadu/fix_hw_interface_check branch January 16, 2024 14:03
@omichel
Copy link
Member

omichel commented Jan 16, 2024

By the way, I sent you an invite to become a member of the webots-committers group, so that you will be able to create branches and PRs on this repository for which the CI test can run.

@Yadunund
Copy link
Member Author

By the way, I sent you an invite to become a member of the webots-committers group, so that you will be able to create branches and PRs on this repository for which the CI test can run.

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Build Issues on ROS 2 Buildfarm for Rolling
2 participants